Merge lp:~dannf/debian-installer/arm64-cleanup into lp:~ubuntu-core-dev/debian-installer/ubuntu
| Status: | Rejected |
|---|---|
| Rejected by: | Mathieu Trudel-Lapierre on 2015-05-13 |
| Proposed branch: | lp:~dannf/debian-installer/arm64-cleanup |
| Merge into: | lp:~ubuntu-core-dev/debian-installer/ubuntu |
| Diff against target: |
639 lines (+433/-18) (has conflicts) 18 files modified
build/Makefile (+22/-0) build/boot/README.device-tree (+2/-0) build/boot/arm64/grub/grub-efi.cfg (+3/-0) build/config/arm64.cfg (+93/-5) build/config/arm64/cdrom.cfg (+3/-0) build/config/arm64/cdrom/grub.cfg (+8/-0) build/config/arm64/device-tree.cfg (+4/-0) build/config/arm64/generic.cfg (+0/-7) build/config/arm64/netboot.cfg (+37/-0) build/config/dir (+2/-0) build/pkg-lists/cdrom/arm64.cfg (+11/-0) build/pkg-lists/cdrom/grub/arm64.cfg (+2/-0) build/pkg-lists/device-tree/arm64.cfg (+1/-0) build/pkg-lists/device-tree/common (+1/-0) build/util/efi-image (+7/-1) build/util/grub-gencfg (+210/-0) debian/changelog (+22/-0) debian/control (+5/-5) Text conflict in build/config/arm64.cfg Conflict: can't delete build/config/arm64/generic because it is not empty. Not deleting. Conflict because build/config/arm64/generic is not versioned, but has versioned children. Versioned directory. Contents conflict in build/config/arm64/generic/netboot.cfg Text conflict in debian/changelog |
| To merge this branch: | bzr merge lp:~dannf/debian-installer/arm64-cleanup |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Mathieu Trudel-Lapierre | 2015-02-14 | Disapprove on 2015-05-13 | |
| Scott Moser | 2015-02-14 | Pending | |
|
Review via email:
|
|||
Description of the Change
This is a series of cleanups for the arm64 netboot build. Quick highlights:
- Use mklibs
- Get rid of "generic" in directory hiearchy
- Rename "xgene" to "xgene-uboot"
- Provide all available dtbs
- Add a netboot tarball (will add grub/uboot-pxe confs later)
- Generally more in-line w/ Debian
I strongly recommend reviewing each commit individually, esp. since files are getting moved around. I've tried to keep a commit per functional change.
| dann frazier (dannf) wrote : | # |
- 2048. By dann frazier on 2015-02-18
-
arm64: Create a netboot tarball
As we start adding more content to the netboot directory - like configuration
files and bootloaders for PXE - it will become a pain to have to download each
file individually. Follow other architectures and generate netboot.tar.gz.
| dann frazier (dannf) wrote : | # |
fyi, this should take care of the necessary lp:maas-images changes:
https:/
- 2049. By dann frazier on 2015-02-19
-
Cleanup unused MANIFEST entries
Now that we're generating a netboot tarball, the MANIFEST entries for the
individual components are unused. - 2050. By dann frazier on 2015-02-19
-
arm64: Add netboot mini.iso (from Debian)
- 2051. By dann frazier on 2015-02-19
-
Include a useful grub.cfg for arm64 (from Debian)
- 2052. By dann frazier on 2015-02-19
-
arm64: Build cdrom flavor (from Debian)
- 2053. By dann frazier on 2015-02-19
-
Use grub-gencfg for cdrom image as well
- 2054. By dann frazier on 2015-02-19
-
netboot bits
- 2055. By dann frazier on 2015-03-19
-
Fix typo in build-deps
| Sebastien Bacher (seb128) wrote : | # |
I didn't review that one bug the summary lists merge conflicts, those might need to be resolved?
| Mathieu Trudel-Lapierre (cyphermox) wrote : | # |
Rejecting; I asked dann and it looks like this is included in another merge (https:/
Unmerged revisions
- 2055. By dann frazier on 2015-03-19
-
Fix typo in build-deps
- 2054. By dann frazier on 2015-02-19
-
netboot bits
- 2053. By dann frazier on 2015-02-19
-
Use grub-gencfg for cdrom image as well
- 2052. By dann frazier on 2015-02-19
-
arm64: Build cdrom flavor (from Debian)
- 2051. By dann frazier on 2015-02-19
-
Include a useful grub.cfg for arm64 (from Debian)
- 2050. By dann frazier on 2015-02-19
-
arm64: Add netboot mini.iso (from Debian)

@Scott - I've requested your review here because this will require corresponding changes to the maas-images simple stream:
netboot/ generic/ vmlinuz -> netboot/vmlinuz generic/ initrd. gz -> netboot/initrd.gz generic/ xgene/uImage -> netboot/ xgene-uboot/ uImage generic/ xgene/uInitrd -> netboot/ xgene-uboot/ uInitrd generic/ xgene/apm- mustang. dtb -> device- tree/apm- mustang. dtb
netboot/
netboot/
netboot/
netboot/