Code review comment for lp:~dannf/debian-cd/lp1692876
Revision history for this message
| dann frazier (dannf) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
35a32c5
(Get the code!)
@scdbackup: Thanks for the detailed explanation! I've pushed a new branch here which tries to evolve our code w/ your recommendations, and it seems to work for me:
https:/
(I'm not sure if there's a way to force push that over this branch so that the MP comments here remain associated)
It's a series of commits that tries to explain the rationale behind each change - would you mind taking a look to see that I've accurately understood?
Two things I did not (yet) include are the change from -efi-boot to -e and the addition of -no-pad. I'm not sure I understand the difference the former makes in our use case. The latter seems to be for images that are not intended to be burned, while this one certainly could be. Is there a reason that it is no longer relevant?