Merge lp:~danilovesky/workcraft/trunk-bug-1350787 into lp:workcraft

Proposed by Danil Sokolov
Status: Merged
Merged at revision: 596
Proposed branch: lp:~danilovesky/workcraft/trunk-bug-1350787
Merge into: lp:workcraft
Diff against target: 267 lines (+79/-56)
5 files modified
WorkcraftCore/src/org/workcraft/Info.java (+1/-1)
WorkcraftCore/src/org/workcraft/gui/MainWindow.java (+76/-47)
build_distr.sh (+0/-6)
build_distr_linux.sh (+1/-1)
build_distr_windows.sh (+1/-1)
To merge this branch: bzr merge lp:~danilovesky/workcraft/trunk-bug-1350787
Reviewer Review Type Date Requested Status
Danil Sokolov Approve
Review via email: mp+253206@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Danil Sokolov (danilovesky) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'WorkcraftCore/src/org/workcraft/Info.java'
--- WorkcraftCore/src/org/workcraft/Info.java 2015-02-28 23:14:51 +0000
+++ WorkcraftCore/src/org/workcraft/Info.java 2015-03-17 14:02:13 +0000
@@ -13,7 +13,7 @@
13 private static final int majorVersion = 3;13 private static final int majorVersion = 3;
14 private static final int minorVersion = 0;14 private static final int minorVersion = 0;
15 private static final int revisionVersion = 4;15 private static final int revisionVersion = 4;
16 private static final String statusVersion = "alpha"; // alpha, beta, rc1, rc216 private static final String statusVersion = null; // "alpha", "beta", "rc1", null (for release)
1717
18 private static final int startYear = 2006;18 private static final int startYear = 2006;
19 private static final int currentYear = Calendar.getInstance().get(Calendar.YEAR);19 private static final int currentYear = Calendar.getInstance().get(Calendar.YEAR);
2020
=== modified file 'WorkcraftCore/src/org/workcraft/gui/MainWindow.java'
--- WorkcraftCore/src/org/workcraft/gui/MainWindow.java 2015-02-10 15:21:12 +0000
+++ WorkcraftCore/src/org/workcraft/gui/MainWindow.java 2015-03-17 14:02:13 +0000
@@ -23,8 +23,12 @@
2323
24import java.awt.BorderLayout;24import java.awt.BorderLayout;
25import java.awt.Color;25import java.awt.Color;
26import java.awt.DisplayMode;
26import java.awt.Font;27import java.awt.Font;
28import java.awt.Insets;
27import java.awt.Point;29import java.awt.Point;
30import java.awt.Rectangle;
31import java.awt.Toolkit;
28import java.awt.event.WindowAdapter;32import java.awt.event.WindowAdapter;
29import java.awt.event.WindowEvent;33import java.awt.event.WindowEvent;
30import java.awt.font.FontRenderContext;34import java.awt.font.FontRenderContext;
@@ -346,6 +350,21 @@
346 utilityWindows.add(dockableWindow);350 utilityWindows.add(dockableWindow);
347 }351 }
348352
353 public void setWindowSize(boolean maximised, int width, int height){
354 if(maximised){
355 DisplayMode mode = this.getGraphicsConfiguration().getDevice().getDisplayMode();
356 Insets insets = Toolkit.getDefaultToolkit().getScreenInsets(this.getGraphicsConfiguration());
357 this.setMaximizedBounds(new Rectangle(
358 mode.getWidth() - insets.right - insets.left,
359 mode.getHeight() - insets.top - insets.bottom
360 ));
361 this.setExtendedState(this.getExtendedState() | JFrame.MAXIMIZED_BOTH);
362 this.setSize(mode.getWidth() - insets.right - insets.left, mode.getHeight() - insets.top - insets.bottom);
363 }else{
364 this.setExtendedState(JFrame.NORMAL);
365 }
366 }
367
349 public void startup() {368 public void startup() {
350 MainWindowIconManager.apply(this);369 MainWindowIconManager.apply(this);
351370
@@ -375,13 +394,6 @@
375 rootDockingPort = new DefaultDockingPort("defaultDockingPort");394 rootDockingPort = new DefaultDockingPort("defaultDockingPort");
376 content.add(rootDockingPort, BorderLayout.CENTER);395 content.add(rootDockingPort, BorderLayout.CENTER);
377396
378 boolean maximised = Boolean.parseBoolean(framework
379 .getConfigVar("gui.main.maximised"));
380 String w = framework.getConfigVar("gui.main.width");
381 String h = framework.getConfigVar("gui.main.height");
382 int width = (w == null) ? 800 : Integer.parseInt(w);
383 int height = (h == null) ? 600 : Integer.parseInt(h);
384
385 lastSavePath = framework.getConfigVar("gui.main.lastSavePath");397 lastSavePath = framework.getConfigVar("gui.main.lastSavePath");
386 lastOpenPath = framework.getConfigVar("gui.main.lastOpenPath");398 lastOpenPath = framework.getConfigVar("gui.main.lastOpenPath");
387 for (int i = 0; i < CommonEditorSettings.getRecentCount(); i++) {399 for (int i = 0; i < CommonEditorSettings.getRecentCount(); i++) {
@@ -390,12 +402,23 @@
390 }402 }
391 mainMenu.setRecentMenu(new ArrayList<String>(recentFiles));403 mainMenu.setRecentMenu(new ArrayList<String>(recentFiles));
392404
405 String maximisedStr = framework.getConfigVar("gui.main.maximised");
406 String widthStr = framework.getConfigVar("gui.main.width");
407 String heightStr = framework.getConfigVar("gui.main.height");
408
409 boolean maximised = (maximisedStr == null) ? true : Boolean.parseBoolean(maximisedStr);
410 this.setExtendedState(maximised ? JFrame.MAXIMIZED_BOTH : JFrame.NORMAL);
411
412 DisplayMode mode = this.getGraphicsConfiguration().getDevice().getDisplayMode();
413 Insets insets = Toolkit.getDefaultToolkit().getScreenInsets(this.getGraphicsConfiguration());
414 int width = mode.getWidth() - insets.right - insets.left;
415 int height = mode.getHeight() - insets.top - insets.bottom;
416 if ((widthStr != null) && (heightStr != null)) {
417 width = Integer.parseInt(widthStr);
418 height = Integer.parseInt(heightStr);
419 }
393 this.setSize(width, height);420 this.setSize(width, height);
394421
395 if (maximised) {
396 setExtendedState(MAXIMIZED_BOTH);
397 }
398
399 createWindows();422 createWindows();
400423
401 outputWindow.captureStream();424 outputWindow.captureStream();
@@ -404,44 +427,50 @@
404 rootDockingPort.setBorderManager(new StandardBorderManager(427 rootDockingPort.setBorderManager(new StandardBorderManager(
405 new ShadowBorder()));428 new ShadowBorder()));
406429
407 outputDockable = createDockableWindow(outputWindow, "Output",430 float xSplit = 0.88f;
408 DockableWindowContentPanel.CLOSE_BUTTON,431 float ySplit = 0.82f;
409 DockingManager.SOUTH_REGION, 0.8f);432 outputDockable = createDockableWindow(
410 433 outputWindow, "Output",
411 DockableWindow problems = createDockableWindow(errorWindow, "Problems",434 DockableWindowContentPanel.CLOSE_BUTTON,
412 outputDockable, DockableWindowContentPanel.CLOSE_BUTTON);435 DockingManager.SOUTH_REGION, ySplit);
413 436
414 437 DockableWindow problems = createDockableWindow(
415 DockableWindow javaScript = createDockableWindow(jsWindow,438 errorWindow, "Problems", outputDockable,
416 "Javascript", outputDockable,439 DockableWindowContentPanel.CLOSE_BUTTON);
417 DockableWindowContentPanel.CLOSE_BUTTON);440
418441 DockableWindow javaScript = createDockableWindow(
419 DockableWindow wsvd = createDockableWindow(workspaceWindow,442 jsWindow, "Javascript", outputDockable,
420 "Workspace", DockableWindowContentPanel.CLOSE_BUTTON,443 DockableWindowContentPanel.CLOSE_BUTTON);
421 DockingManager.EAST_REGION, 0.8f);444
445 DockableWindow wsvd = createDockableWindow(
446 workspaceWindow, "Workspace",
447 DockableWindowContentPanel.CLOSE_BUTTON,
448 DockingManager.EAST_REGION, xSplit);
449
422 DockableWindow propertyEditor = createDockableWindow(450 DockableWindow propertyEditor = createDockableWindow(
423 propertyEditorWindow, "Property editor", wsvd,451 propertyEditorWindow, "Property editor", wsvd,
424 DockableWindowContentPanel.CLOSE_BUTTON,452 DockableWindowContentPanel.CLOSE_BUTTON,
425 DockingManager.NORTH_REGION, 0.5f);453 DockingManager.NORTH_REGION, ySplit);
426 DockableWindow toolbox = createDockableWindow(toolboxWindow,454
427 "Editor tools", propertyEditor,455 DockableWindow tiw = createDockableWindow(
428 DockableWindowContentPanel.HEADER456 toolInterfaceWindow, "Tool controls", propertyEditor,
429 | DockableWindowContentPanel.CLOSE_BUTTON,
430 DockingManager.SOUTH_REGION, 0.5f);
431 DockableWindow tiw = createDockableWindow(toolInterfaceWindow,
432 "Tool controls", toolbox,
433 DockableWindowContentPanel.CLOSE_BUTTON,457 DockableWindowContentPanel.CLOSE_BUTTON,
434 DockingManager.SOUTH_REGION, 0.5f);458 DockingManager.SOUTH_REGION, 0.4f);
435459
436 documentPlaceholder = createDockableWindow(new DocumentPlaceholder(),460 DockableWindow toolbox = createDockableWindow(
437 "", null, outputDockable, 0, DockingManager.NORTH_REGION, 0.8f,461 toolboxWindow, "Editor tools", tiw,
438 "DocumentPlaceholder");462 DockableWindowContentPanel.HEADER | DockableWindowContentPanel.CLOSE_BUTTON,
463 DockingManager.SOUTH_REGION, 0.82f);
464
465 documentPlaceholder = createDockableWindow(
466 new DocumentPlaceholder(), "", null, outputDockable,
467 0, DockingManager.NORTH_REGION, ySplit, "DocumentPlaceholder");
439468
440 DockingManager.display(outputDockable);469 DockingManager.display(outputDockable);
441 EffectsManager.setPreview(new AlphaPreview(Color.BLACK, Color.GRAY,470 EffectsManager.setPreview(new AlphaPreview(Color.BLACK, Color.GRAY, 0.5f));
442 0.5f));
443471
444 DockableWindow tasks = createDockableWindow(new TaskManagerWindow(), "Tasks", outputDockable,472 DockableWindow tasks = createDockableWindow(
473 new TaskManagerWindow(), "Tasks", outputDockable,
445 DockableWindowContentPanel.CLOSE_BUTTON);474 DockableWindowContentPanel.CLOSE_BUTTON);
446475
447 setVisible(true);476 setVisible(true);
@@ -718,8 +747,9 @@
718 saveDockingLayout();747 saveDockingLayout();
719748
720 content.remove(rootDockingPort);749 content.remove(rootDockingPort);
721750
722 framework.setConfigVar("gui.main.maximised", Boolean.toString((getExtendedState() & JFrame.MAXIMIZED_BOTH) != 0));751 boolean maximised = ((getExtendedState() & JFrame.MAXIMIZED_BOTH) != 0);
752 framework.setConfigVar("gui.main.maximised", Boolean.toString(maximised));
723 framework.setConfigVar("gui.main.width", Integer.toString(getWidth()));753 framework.setConfigVar("gui.main.width", Integer.toString(getWidth()));
724 framework.setConfigVar("gui.main.height", Integer.toString(getHeight()));754 framework.setConfigVar("gui.main.height", Integer.toString(getHeight()));
725755
@@ -928,7 +958,6 @@
928 }958 }
929 openWork(f);959 openWork(f);
930 }960 }
931 lastOpenPath = fc.getCurrentDirectory().getPath();
932 } else {961 } else {
933 throw new OperationCancelledException("Open operation cancelled by user.");962 throw new OperationCancelledException("Open operation cancelled by user.");
934 }963 }
@@ -943,6 +972,7 @@
943 createEditorWindow(we);972 createEditorWindow(we);
944 }973 }
945 pushRecentFile(f.getPath(), true);974 pushRecentFile(f.getPath(), true);
975 lastOpenPath = f.getParent();
946 } catch (DeserialisationException e) {976 } catch (DeserialisationException e) {
947 JOptionPane.showMessageDialog(this,977 JOptionPane.showMessageDialog(this,
948 "A problem was encountered while trying to load \"" + f.getPath() + "\".\n" 978 "A problem was encountered while trying to load \"" + f.getPath() + "\".\n"
@@ -964,7 +994,6 @@
964 }994 }
965 mergeWork(f);995 mergeWork(f);
966 }996 }
967 lastOpenPath = fc.getCurrentDirectory().getPath();
968 } else {997 } else {
969 throw new OperationCancelledException("Merge operation cancelled by user.");998 throw new OperationCancelledException("Merge operation cancelled by user.");
970 }999 }
@@ -1098,7 +1127,6 @@
1098 for (File f : fc.getSelectedFiles()) {1127 for (File f : fc.getSelectedFiles()) {
1099 importFrom(f, importers);1128 importFrom(f, importers);
1100 }1129 }
1101 lastOpenPath = fc.getCurrentDirectory().getPath();
1102 }1130 }
1103 }1131 }
11041132
@@ -1111,6 +1139,7 @@
1111 ModelEntry me = Import.importFromFile(importer, f);1139 ModelEntry me = Import.importFromFile(importer, f);
1112 me.getModel().setTitle(FileUtils.getFileNameWithoutExtension(f));1140 me.getModel().setTitle(FileUtils.getFileNameWithoutExtension(f));
1113 framework.getWorkspace().add(Path.<String> empty(), f.getName(), me, false, me.isVisual());1141 framework.getWorkspace().add(Path.<String> empty(), f.getName(), me, false, me.isVisual());
1142 lastOpenPath = f.getParent();
1114 break;1143 break;
1115 } catch (IOException e) {1144 } catch (IOException e) {
1116 e.printStackTrace();1145 e.printStackTrace();
11171146
=== modified file 'build_distr.sh'
--- build_distr.sh 2015-01-26 22:10:33 +0000
+++ build_distr.sh 2015-03-17 14:02:13 +0000
@@ -92,9 +92,3 @@
92do92do
93 cp -r $src_dir/$i $distr_dir/93 cp -r $src_dir/$i $distr_dir/
94done94done
95
96# Copy config
97if [ -e $src_dir/config ]
98then
99 cp -r $src_dir/config $distr_dir/
100fi
10195
=== modified file 'build_distr_linux.sh'
--- build_distr_linux.sh 2015-02-28 23:14:51 +0000
+++ build_distr_linux.sh 2015-03-17 14:02:13 +0000
@@ -1,7 +1,7 @@
1#!/usr/bin/env bash1#!/usr/bin/env bash
22
3src_dir="."3src_dir="."
4distr_dir="../../workcraft_3.0.4_alpha"4distr_dir="../../workcraft_3.0.4"
5template_dir="../../distr-template-linux"5template_dir="../../distr-template-linux"
66
7./build_distr.sh -s $src_dir -d $distr_dir -t $template_dir7./build_distr.sh -s $src_dir -d $distr_dir -t $template_dir
88
=== modified file 'build_distr_windows.sh'
--- build_distr_windows.sh 2015-02-28 23:14:51 +0000
+++ build_distr_windows.sh 2015-03-17 14:02:13 +0000
@@ -1,7 +1,7 @@
1#!/usr/bin/env bash1#!/usr/bin/env bash
22
3src_dir="."3src_dir="."
4distr_dir="../../workcraft_3.0.4_alpha"4distr_dir="../../workcraft_3.0.4"
5template_dir="../../distr-template-windows"5template_dir="../../distr-template-windows"
66
7./build_distr.sh -s $src_dir -d $distr_dir -t $template_dir7./build_distr.sh -s $src_dir -d $distr_dir -t $template_dir

Subscribers

People subscribed via source and target branches