Hi Danilos thanks for fixing this bug. I'm especially happy since it is one I opened.
On IRC we identified some issues that can be addressed in your follow-on branch:
- In the overlay form, change the value of the teams to have the '/~' prefixed which will prevent any future clashes between valid team names and the other checkbox values in the form.
- Rename and change the description of 'unsubscribe_current_user' to reflect the larger scope of what it is doing. In this case you're using it to unsubscribe a team.
With the promised follow-on branch work this one is ok.
Hi Danilos thanks for fixing this bug. I'm especially happy since it is one I opened.
On IRC we identified some issues that can be addressed in your follow-on branch:
- In the overlay form, change the value of the teams to have the '/~' prefixed which will prevent any future clashes between valid team names and the other checkbox values in the form.
- Rename and change the description of 'unsubscribe_ current_ user' to reflect the larger scope of what it is doing. In this case you're using it to unsubscribe a team.
With the promised follow-on branch work this one is ok.