Merge lp:~danilo/launchpad/bug-761257 into lp:launchpad
Status: | Merged |
---|---|
Approved by: | Данило Шеган |
Approved revision: | no longer in the source branch. |
Merged at revision: | 12909 |
Proposed branch: | lp:~danilo/launchpad/bug-761257 |
Merge into: | lp:launchpad |
Diff against target: |
167 lines (+86/-26) 2 files modified
lib/lp/bugs/javascript/bug_subscription.js (+10/-4) lib/lp/bugs/javascript/bugtask_index_portlets.js (+76/-22) |
To merge this branch: | bzr merge lp:~danilo/launchpad/bug-761257 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Brad Crittenden (community) | code | Approve | |
Review via email: mp+58801@code.launchpad.net |
Commit message
[r=bac][bug=761257] Allow teams to be unsubscribed from the advanced subscription overlay.
Description of the change
= Bug 761257 =
Advanced bug subscription overlay UI shows an option to unsubscribe any of the teams that you have privileges for. However, choosing those options doesn't really work.
== Proposed fix ==
We need to factor handle_
a. updating existing subscription
b. unmuting and subscribing with a different notification level
c. unmuting
d. unsubscribing teams
Case b. is equivalent to a. and is treated as such, so we've got only a conditional for a/c/d.
== Implementation details ==
I also fixed a very jumpy animation (it always slided out a list of bug notification levels when you had a bug muted), and (not so) accidentally fixed the case of "unmuting" not really allowing to set a bug notification level even if the UI offered it.
== Tests ==
No tests. I am doing a refactoring branch that will include tests for this separately.
== Demo and Q/A ==
https:/
https:/
The demo at
https:/
shows approximatelly what steps need to be taken for proper QA. Refreshing between steps will help ensure you've got the data updated (and not just the UI), and will avoid a bug in existing code that when you get rid of all subscribers, subscribing someone else stops working.
= Launchpad lint =
Checking for conflicts and issues in changed files.
Linting changed files:
lib/lp/
lib/lp/
Hi Danilos thanks for fixing this bug. I'm especially happy since it is one I opened.
On IRC we identified some issues that can be addressed in your follow-on branch:
- In the overlay form, change the value of the teams to have the '/~' prefixed which will prevent any future clashes between valid team names and the other checkbox values in the form.
- Rename and change the description of 'unsubscribe_ current_ user' to reflect the larger scope of what it is doing. In this case you're using it to unsubscribe a team.
With the promised follow-on branch work this one is ok.