Merge lp:~dandrader/unity-mir/lp1248795 into lp:unity-mir

Proposed by Daniel d'Andrada
Status: Merged
Approved by: Gerry Boland
Approved revision: 159
Merged at revision: 159
Proposed branch: lp:~dandrader/unity-mir/lp1248795
Merge into: lp:unity-mir
Diff against target: 14 lines (+2/-2)
1 file modified
src/modules/Unity/Application/OSKController.qml (+2/-2)
To merge this branch: bzr merge lp:~dandrader/unity-mir/lp1248795
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Gerry Boland (community) Approve
Review via email: mp+198731@code.launchpad.net

Commit message

Fix OSKController.enabled property

OSKController.enabled was always True as we were missing the check for undefined.

Also s/variant/var as the "variant" QML type is deprecated.

To post a comment you must log in.
Revision history for this message
Gerry Boland (gerboland) wrote :

LGTM

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/modules/Unity/Application/OSKController.qml'
--- src/modules/Unity/Application/OSKController.qml 2013-10-14 18:39:55 +0000
+++ src/modules/Unity/Application/OSKController.qml 2013-12-12 12:46:09 +0000
@@ -20,8 +20,8 @@
2020
21Item {21Item {
22 id: root22 id: root
23 property variant __oskSurface: null23 property var __oskSurface: null
24 readonly property bool enabled: __oskSurface !== null24 readonly property bool enabled: __oskSurface !== null && __oskSurface !== undefined
2525
26 UbuntuKeyboardInfo {26 UbuntuKeyboardInfo {
27 id: ubuntuKeyboardInfo27 id: ubuntuKeyboardInfo

Subscribers

People subscribed via source and target branches