Code review comment for lp:~dandrader/unity-api/surfaceDrawn

Revision history for this message
Daniel d'Andrada (dandrader) wrote :

On 12/05/2016 05:44, Nick Dedekind wrote:
> Review: Needs Fixing
>
> perhaps we should make it a bit broader?
> "readyToShow"?

I prefer a property name that maps more closely what's behind it. So
there's no (or little) risk of it overlapping with some other existing
or future property both in functionality and meaning.

And, more importantly, I also think it's a good practice to name
properties/functions after what they do, not after what you plan to use
them for (or connect to). MirSurface should have no say at all over
whether it should be shown in the qmlscene or not. That's up to the
application code (unity8) and its usage of MirSurfaceItems. So in a way
this name weakens the encapsulation of MirSurface.

« Back to merge proposal