Merge lp:~dandrader/unity-api/surfaceDrawn into lp:unity-api

[Daniel d'Andrada]

Added MirSurfaceInterface.drawn property

Needed by:
https://code.launchpad.net/~dandrader/unity8/surfaceDrawn/+merge/294427
https://code.launchpad.net/~dandrader/qtmir/surfaceDrawn/+merge/294428

[Unity8 CI Bot (unity8-ci-bot)]

FAILED: Continuous integration, rev:230
https://unity8-jenkins.ubuntu.com/job/lp-unity-api-ci/74/
Executed test runs:
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/1598/console

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity-api-ci/74/rebuild

review: Needs Fixing (continuous-integration)

[Nick Dedekind (nick-dedekind)]

perhaps we should make it a bit broader?
"readyToShow"?

review: Needs Fixing

[Daniel d'Andrada (dandrader)]

On 12/05/2016 05:44, Nick Dedekind wrote:
> Review: Needs Fixing
>
> perhaps we should make it a bit broader?
> "readyToShow"?

I prefer a property name that maps more closely what's behind it. So
there's no (or little) risk of it overlapping with some other existing
or future property both in functionality and meaning.

And, more importantly, I also think it's a good practice to name
properties/functions after what they do, not after what you plan to use
them for (or connect to). MirSurface should have no say at all over
whether it should be shown in the qmlscene or not. That's up to the
application code (unity8) and its usage of MirSurfaceItems. So in a way
this name weakens the encapsulation of MirSurface.

[Daniel d'Andrada (dandrader)]

This is not enough for bug 1581559

review: Disapprove

Unmerged revisions

230. By Daniel d'Andrada on 2016-05-11

Added MirSurfaceInterface.drawn property

=== modified file 'debian/changelog'
--- debian/changelog	2016-04-26 15:31:50 +0000
+++ debian/changelog	2016-05-11 20:24:13 +0000
@@ -1,3 +1,9 @@
+unity-api (7.112) UNRELEASED; urgency=medium
+
+  * Added MirSurfaceInterface.drawn property
+
+ -- Daniel d'Andrada <[e-mail]>  Wed, 11 May 2016 14:55:45 -0300
+
 unity-api (7.111+16.04.20160426.2-0ubuntu1) xenial; urgency=medium
 
   [ Pawel Stolowski ]

=== modified file 'include/unity/shell/application/CMakeLists.txt'
--- include/unity/shell/application/CMakeLists.txt	2016-04-13 16:40:06 +0000
+++ include/unity/shell/application/CMakeLists.txt	2016-05-11 20:24:13 +0000
@@ -7,7 +7,7 @@
 
 set(UNITY_API_LIB_HDRS ${UNITY_API_LIB_HDRS} ${headers} ${internal_headers} PARENT_SCOPE)
 
-set(VERSION 15)
+set(VERSION 16)
 set(PKGCONFIG_NAME "unity-shell-application")
 set(PKGCONFIG_DESCRIPTION "Unity shell Application APIs")
 set(PKGCONFIG_REQUIRES "Qt5Core")

=== modified file 'include/unity/shell/application/MirSurfaceInterface.h'
--- include/unity/shell/application/MirSurfaceInterface.h	2016-04-13 16:47:27 +0000
+++ include/unity/shell/application/MirSurfaceInterface.h	2016-05-11 20:24:13 +0000
@@ -139,6 +139,15 @@
      */
     Q_PROPERTY(unity::shell::application::MirSurfaceListInterface* promptSurfaceList READ promptSurfaceList CONSTANT)
 
+
+    /**
+     * @brief Whether the surface has drawn its first frame
+     *
+     * It will be true if this surface has already drawn its first frame or false if it's
+     * still blank.
+     */
+    Q_PROPERTY(bool drawn READ drawn NOTIFY drawnChanged)
+
 public:
     /// @cond
     MirSurfaceInterface(QObject *parent = nullptr) : QObject(parent) {}
@@ -177,6 +186,8 @@
     virtual bool focused() const = 0;
 
     virtual MirSurfaceListInterface* promptSurfaceList() = 0;
+
+    virtual bool drawn() const = 0;
     /// @endcond
 
     /**
@@ -215,6 +226,7 @@
     void shellChromeChanged(Mir::ShellChrome value);
     void keymapChanged(const QString &value);
     void focusedChanged(bool value);
+    void drawnChanged(bool value);
     /// @endcond
 
     /**