Merge lp:~dandrader/qtmir/fixIsPidFocused into lp:qtmir
Proposed by
Daniel d'Andrada
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Gerry Boland | ||||
Approved revision: | 551 | ||||
Merged at revision: | 550 | ||||
Proposed branch: | lp:~dandrader/qtmir/fixIsPidFocused | ||||
Merge into: | lp:qtmir | ||||
Diff against target: |
52 lines (+19/-12) 2 files modified
src/modules/Unity/Application/dbusfocusinfo.cpp (+18/-12) src/modules/Unity/Application/dbusfocusinfo.h (+1/-0) |
||||
To merge this branch: | bzr merge lp:~dandrader/qtmir/fixIsPidFocused | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Unity8 CI Bot (community) | continuous-integration | Approve | |
Gerry Boland (community) | Approve | ||
Review via email: mp+303946@code.launchpad.net |
Commit message
DBusFocusInfo.
Description of the change
* Are there any related MPs required for this MP to build/function as expected? Please list.
No
* Did you perform an exploratory manual test run of your code change and any related functionality?
Yes
* If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
Not applicable
To post a comment you must log in.
- Q_FOREACH (Application* application, m_applications) { www.dvratil. cz/2015/ 06/qt-container s-and-c11- range-based- loops/
+ for (Application* application : m_applications) {
not a blocker, just a hint the original *might* be better. Ref:
http://
Other than that, code looks ok