Code review comment for lp:~dandrader/qtmir/fixIsPidFocused

Revision history for this message
Gerry Boland (gerboland) wrote :

- Q_FOREACH (Application* application, m_applications) {
+ for (Application* application : m_applications) {
not a blocker, just a hint the original *might* be better. Ref:
http://www.dvratil.cz/2015/06/qt-containers-and-c11-range-based-loops/

Other than that, code looks ok

review: Approve

« Back to merge proposal