Code review comment for lp:~dandrader/frame/lp1025297

Revision history for this message
Daniel d'Andrada (dandrader) wrote :

> * The added gtest.m4 file shouldn't have a serial number since it's not
> distributed anywhere. The serial number implies that it was copied in from
> some other distribution.
>
> * The Makefile-xorg-gtest.am removal should be reverted. I think you removed
> it because of issues with the wrong files being included when compiling xorg-
> gtest itself. This has been fixed in the Makefile-xorg-gtest.am shipped
> upstream. It has not been fixed in Ubuntu yet, but you can download the change
> from here:

Done.

« Back to merge proposal