Code review comment for lp:~dandrader/frame/lp1025297

Revision history for this message
Chase Douglas (chasedouglas) wrote :

* The added gtest.m4 file shouldn't have a serial number since it's not distributed anywhere. The serial number implies that it was copied in from some other distribution.

* The Makefile-xorg-gtest.am removal should be reverted. I think you removed it because of issues with the wrong files being included when compiling xorg-gtest itself. This has been fixed in the Makefile-xorg-gtest.am shipped upstream. It has not been fixed in Ubuntu yet, but you can download the change from here:

http://cgit.freedesktop.org/xorg/test/xorg-gtest/commit/?id=3fefcde53f8b69b37baeec61265f2e0190713fe6

Everything else looks good!

review: Needs Fixing

« Back to merge proposal