Code review comment for lp:~danci-emanuel/postorius/UI_dlists_support

Revision history for this message
Emanuel Danci (danci-emanuel) wrote :

> Again, I haven't seen these files before, so I'm a bit in the dark, but the
> changes are simple, and they look sensible.
>
> At line 43, I think that your message should be different -- based on the
> other example, the format seems to be a question. How about: Allow list
> members to (un)subscribe to individual threads?
>
> Also change line ll to say: Enable individual thread subscribe/unsubscribe for
> this list?
>
> I'm betting that line 74 is more than 80 chars long, and you should break it
> -- see how it is done at line 72?
>
> It looks good, but I'll leave this as a comment, in case someone else wants to
> chime in.

I changed the text and I also took care of the line 74. Do you think I should change anything else
to these files before I push the changed code?

Thank you,
Emanuel

« Back to merge proposal