Merge lp:~danci-emanuel/postorius/UI_dlists_support into lp:~danci-emanuel/postorius/postorius_orig

[Emanuel Danci]

[Robin J (robin-jeffries)]

Again, I haven't seen these files before, so I'm a bit in the dark, but the changes are simple, and they look sensible.

At line 43, I think that your message should be different -- based on the other example, the format seems to be a question. How about: Allow list members to (un)subscribe to individual threads?

Also change line ll to say: Enable individual thread subscribe/unsubscribe for this list?

I'm betting that line 74 is more than 80 chars long, and you should break it -- see how it is done at line 72?

It looks good, but I'll leave this as a comment, in case someone else wants to chime in.

[Emanuel Danci (danci-emanuel)]

> Again, I haven't seen these files before, so I'm a bit in the dark, but the
> changes are simple, and they look sensible.
>
> At line 43, I think that your message should be different -- based on the
> other example, the format seems to be a question. How about: Allow list
> members to (un)subscribe to individual threads?
>
> Also change line ll to say: Enable individual thread subscribe/unsubscribe for
> this list?
>
> I'm betting that line 74 is more than 80 chars long, and you should break it
> -- see how it is done at line 72?
>
> It looks good, but I'll leave this as a comment, in case someone else wants to
> chime in.

I changed the text and I also took care of the line 74. Do you think I should change anything else
to these files before I push the changed code?

Thank you,
Emanuel

[Terri (terriko)]

I'm clearing up some of the old merge requests to make sure their statuses are correct, and I'm marking this one as disapprove since the associated mailman core code never happened.

review: Disapprove

Unmerged revisions

71. By Emanuel Danci on 2012-07-10

Contains the UI changes needed for enabling/disabling Dynamic sublists.

70. By Emanuel Danci on 2012-07-10

Contains the UI changes needed for enabling/disabling Dynamic sublists.

69. By Emanuel Danci on 2012-07-10

Contains the UI changes needed for enabling/disabling Dynamic sublists.

68. By Emanuel Danci on 2012-07-10

Contains the UI changes needed for enabling/disabling Dynamic sublists.

67. By Emanuel Danci on 2012-07-09

Contains the UI changes needed for supporing Dynamic sublists

=== modified file 'src/postorius/forms.py'
--- src/postorius/forms.py	2012-03-23 23:22:16 +0000
+++ src/postorius/forms.py	2012-07-10 12:02:18 +0000
@@ -96,6 +96,19 @@
             'required': _("Please enter the list owner's email address."), 
         },
         required = True)
+        
+    dlists_enabled = forms.ChoiceField(
+    	widget = forms.RadioSelect(),
+        label = _("Enable Dynamic sublists feature for this list?"),
+    	error_messages = {
+            'required': _("Please choose an option."), 
+        },
+        required = True,
+        choices = (
+        	(True, _("Enable.")),
+        	(False, _("Do not enable."))
+        ))
+     
     advertised = forms.ChoiceField(
         widget = forms.RadioSelect(),
         label = _('Advertise this list?'), 
@@ -142,7 +155,8 @@
                    "mail_host",
                    "list_owner",
                    "description",
-                   "advertised"],]
+                   "advertised",
+                   "dlists_enabled"],]
 
 class ListSubscribe(FieldsetForm):
     """Form fields to join an existing list.
@@ -302,6 +316,13 @@
         widget = forms.RadioSelect,
         label = _('Advertise the existance of this list?'), 
         )
+
+    dlists_enabled = forms.TypedChoiceField(
+        coerce=lambda x: x =='True',
+        choices=((True, _('Enabled')), (False, _('Disabled'))),
+        widget = forms.RadioSelect, 
+        label = _("Status of the Dynamic sublists feature"),
+        ) 
     filter_content = forms.TypedChoiceField(
         coerce=lambda x: x =='True',
         choices=((True, _('Yes')), (False, _('No'))),
@@ -780,7 +801,8 @@
         # just a really temporary layout to see that it works. -- Anna
         layout = [
             ["List Identity", "display_name", "mail_host", "description", 
-             "advertised"], 
+             "advertised",
+             "dlists_enabled"], 
              #"info", "list_name", "host_name", "list_id", "fqdn_listname", 
              #"http_etag", "volume", "web_host"
             ["Automatic Responses", "autorespond_owner",

=== modified file 'src/postorius/views.py'
--- src/postorius/views.py	2012-05-25 22:37:22 +0000
+++ src/postorius/views.py	2012-07-10 12:02:18 +0000
@@ -45,7 +45,6 @@
 
 logger = logging.getLogger(__name__)
 
-
 @login_required
 @user_passes_test(lambda u: u.is_superuser)
 def site_settings(request):
@@ -123,6 +122,7 @@
                 list_settings["description"] = form.cleaned_data['description']
                 list_settings["owner_address"] = \
                     form.cleaned_data['list_owner']
+                list_settings["dlists_enabled"] = form.cleaned_data['dlists_enabled']
                 list_settings["advertised"] = form.cleaned_data['advertised']
                 list_settings.save()
                 messages.success(request, _("List created"))