Code review comment for lp:~daker/loco-team-portal/fix.1542697

Revision history for this message
Lucy Llewellyn (lucyllewy) wrote :

The modified parameter is not to be set by us. We are supposed to use whatever the server we're fetching-from has previously told us the feed was last modified. We should also have etag functionality included in this MR. See http://pythonhosted.org/feedparser/http-etag.html for details.

Saving the correct last-modified time should be:

self.last_updated = data.modified_parsed

and an etag would be accessed, and saved into a new field, from the response with:

self.last_etag = data.etag

we'd need to add the last_etag field into the model and update the migrations.

review: Needs Fixing

« Back to merge proposal