Merge lp:~daker/loco-team-portal/fix.1542697 into lp:loco-team-portal

[Adnane Belmadiaf]

Fixed feed date parsing

Fixed feed date parsing

[Chris Johnston (cjohnston)]

review: Approve

[Lucy Llewellyn (lucyllewy)]

The modified parameter is not to be set by us. We are supposed to use whatever the server we're fetching-from has previously told us the feed was last modified. We should also have etag functionality included in this MR. See http://pythonhosted.org/feedparser/http-etag.html for details.

Saving the correct last-modified time should be:

self.last_updated = data.modified_parsed

and an etag would be accessed, and saved into a new field, from the response with:

self.last_etag = data.etag

we'd need to add the last_etag field into the model and update the migrations.

review: Needs Fixing

Unmerged revisions

685. By Adnane Belmadiaf on 2016-03-20

Fixed feed date parsing

=== modified file 'Makefile'
--- Makefile	2016-02-12 00:54:37 +0000
+++ Makefile	2016-03-20 15:47:31 +0000
@@ -39,7 +39,7 @@
 	$(django_manage) runserver
 
 test: env apps
-	$(django_manage) test teams events venues meetings userprofiles
+	$(django_manage) test teams events venues meetings userprofiles articles
 
 clean:
 	rm -rf env/

=== modified file 'loco_directory/articles/models.py'
--- loco_directory/articles/models.py	2012-12-25 22:00:46 +0000
+++ loco_directory/articles/models.py	2016-03-20 15:47:31 +0000
@@ -68,7 +68,7 @@
 
         if self.title is None or self.title == '':
             self.title = data.feed.title
-        self.last_updated = datetime.datetime.fromtimestamp(time.mktime(getattr(data, 'modified', time.gmtime())))
+        self.last_updated = datetime.datetime.fromtimestamp(time.mktime(time.gmtime()))
         self.save()
 
         for entry in data.entries: