Provider for Plainbox - PC Sanity

Code review comment for ~cyruslien/plainbox-provider-pc-sanity/+git/plainbox-provider-pc-sanity-2:fix-focal-build-fail

  1. Git
  2. lp:~cyruslien/plainbox-provider-pc-sanity/+git/plainbox-provider-pc-sanity-2
  3. fix-focal-build-fail
  4. Merge into master
Revision history for this message
Shih-Yuan Lee (fourdollars) wrote :

OK. There is an inline shellcheck.

FAIL: test_job_command_units/pc-sanity/pc-sanity-check-devices.pxu:303-335_miscellanea/check-display_{product} (plainbox.provider_manager.InlineShellcheckTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/plainbox/provider_manager.py", line 1575, in run_inline_shellcheck
    self.assertEqual(result.returncode, 0)
AssertionError: 1 != 0

review: Approve

« Back to merge proposal