Merge ~cyruslien/plainbox-provider-pc-sanity/+git/plainbox-provider-pc-sanity-2:fix-focal-build-fail into plainbox-provider-pc-sanity:master

[Cyrus Lien]

[Shih-Yuan Lee (fourdollars)]

I don't get it that we run shellcheck against pc-sanity-check-devices.pxu.

review: Needs Information

[OEM Taipei Bot (oem-taipei-bot)]

[autopkgtest]
help PASS
checkbox-cli-list PASS
bootstrap-pc-sanity PASS
cvescan PASS

https://oem-share.canonical.com/partners/lyoncore/share/artifacts/plainbox-provider-pc-sanity/plainbox-provider-pc-sanity-1.0.2-27c9533-in-linux-container-jammy

[Cyrus Lien (cyruslien)]

> I don't get it that we run shellcheck against pc-sanity-check-devices.pxu.
Here is the ppa build log https://launchpadlibrarian.net/728149971/buildlog_ubuntu-focal-amd64.plainbox-provider-pc-sanity_1.0.2-0~202405060919+e713912~ubuntu20.04.1_BUILDING.txt.gz

[Shih-Yuan Lee (fourdollars)]

OK. There is an inline shellcheck.

FAIL: test_job_command_units/pc-sanity/pc-sanity-check-devices.pxu:303-335_miscellanea/check-display_{product} (plainbox.provider_manager.InlineShellcheckTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/plainbox/provider_manager.py", line 1575, in run_inline_shellcheck
    self.assertEqual(result.returncode, 0)
AssertionError: 1 != 0

review: Approve

[Dirk Su (dirksu)]

SC2230 deprecated after shellcheck v0.7.1 https://github.com/koalaman/shellcheck/blob/master/CHANGELOG.md#changed-4

LGTM

review: Approve

diff --git a/units/pc-sanity/pc-sanity-check-devices.pxu b/units/pc-sanity/pc-sanity-check-devices.pxu
index ecc2028..5545cef 100644
--- a/units/pc-sanity/pc-sanity-check-devices.pxu
+++ b/units/pc-sanity/pc-sanity-check-devices.pxu
@@ -309,6 +309,7 @@ plugin: shell
 category_id: com.canonical.plainbox::miscellanea
 id: miscellanea/check-display_{product}
 command:
+ # shellcheck disable=SC2230
  UWAKE=$(which uwake)   # sudo doesn't inherit current $PATH
  sudo "$UWAKE"          # src: c/uwake.c
  sleep 5                # wait the screen to be on