Code review comment for ~cypressyew/plainbox-provider-canonical-certification:server-hwe-attachment

Revision history for this message
Po-Hsu Lin (cypressyew) wrote :

Since we have a new flag (--qa and --hwe) in the fwts_test script,
if we just run:
 fwts_test -l $PLAINBOX_SESSION_SHARE/fwts_results.log

It will run all the test cases in both QA and HWE test list:
CERT_TESTS = sorted(QA_TESTS + HWE_TESTS)

And store the log in to the assigned file, which is fwts_results.log in this case.

So in short,
we don't need this fix in the server provider, as we don't separate --hwe and --qatest cases like what we did in the client provider.

review: Disapprove

« Back to merge proposal