Merge ~cypressyew/plainbox-provider-canonical-certification:server-hwe-attachment into plainbox-provider-canonical-certification:master-server

Proposed by Po-Hsu Lin
Status: Rejected
Rejected by: Po-Hsu Lin
Proposed branch: ~cypressyew/plainbox-provider-canonical-certification:server-hwe-attachment
Merge into: plainbox-provider-canonical-certification:master-server
Diff against target: 24 lines (+2/-0)
2 files modified
units/server-full-14.04.pxu (+1/-0)
units/server-soc-cert.pxu (+1/-0)
Reviewer Review Type Date Requested Status
Po-Hsu Lin Disapprove
Jeff Lane  Pending
Review via email: mp+269628@code.launchpad.net

Description of the change

Add the HWE attachment job to reflect the recent change in fwts_test script.

It should land with this branch[1]

We could merge these two sets later (the one in firmware/ and miscellanea/)

[1] https://code.launchpad.net/~cypressyew/checkbox/server-fwts-hwe-attachment/+merge/269627

To post a comment you must log in.
Revision history for this message
Po-Hsu Lin (cypressyew) wrote :

If a newer version of fwts_test[1] has landed, we won't need this fwts_result_hwe.log job anymore (unless we need to split the fwts log report for hwe), please feel free to reject this MR, or change it into need fixing if we need to split the log.

Thanks!

[1] https://code.launchpad.net/~cypressyew/checkbox/fwts-hwe-test/+merge/269711

Revision history for this message
Po-Hsu Lin (cypressyew) wrote :

Since we have a new flag (--qa and --hwe) in the fwts_test script,
if we just run:
 fwts_test -l $PLAINBOX_SESSION_SHARE/fwts_results.log

It will run all the test cases in both QA and HWE test list:
CERT_TESTS = sorted(QA_TESTS + HWE_TESTS)

And store the log in to the assigned file, which is fwts_results.log in this case.

So in short,
we don't need this fix in the server provider, as we don't separate --hwe and --qatest cases like what we did in the client provider.

review: Disapprove

Unmerged commits

15b855b... by Po-Hsu Lin

provider:server add the hwe attachment job for fwts test

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/units/server-full-14.04.pxu b/units/server-full-14.04.pxu
2index 6508a6b..62e41ea 100644
3--- a/units/server-full-14.04.pxu
4+++ b/units/server-full-14.04.pxu
5@@ -38,6 +38,7 @@ include:
6 miscellanea/get_maas_version
7 miscellanea/fwts_test
8 miscellanea/fwts_results.log
9+ miscellanea/fwts_results_hwe.log
10 miscellanea/ipmi_test
11 miscellanea/bmc_info
12 __benchmarks__
13diff --git a/units/server-soc-cert.pxu b/units/server-soc-cert.pxu
14index d5c4d66..86257de 100644
15--- a/units/server-soc-cert.pxu
16+++ b/units/server-soc-cert.pxu
17@@ -34,6 +34,7 @@ include:
18 miscellanea/dmitest_server
19 miscellanea/fwts_test
20 miscellanea/fwts_results.log
21+ miscellanea/fwts_results_hwe.log
22 __benchmarks__
23 benchmarks/disk/hdparm-read
24 benchmarks/disk/hdparm-read_.*

Subscribers

People subscribed via source and target branches