Code review comment for lp:~cyphermox/ubiquity/disable-verification

Revision history for this message
Dimitri John Ledkov (xnox) wrote :

secureboot signatures seem to be wrong on the xenial proposed images, or my new laptop has broken firmware.

posted the dialogs and text for mpt to look at, in the bug report https://bugs.launchpad.net/ubuntu/+source/ubiquity/+bug/1524833
maybe he can improve design or text.

Text in the learn more button, probably lacks the styles and/or attributed to actually parse the html-y tags -> cause it says literarly <span forground.... instead of making Warning red.

The info loop seems to be wrong.

It starts with both password fields empty, the second one has green tick box already (should be blank) and continue button is active.

The strength indicators work correctly.

Passwords do not match indicator is wrong:
both empty -> green mark & continue button active;
both filled and matching -> "passwords do not match" and continue button inactive

mokutil in in universe, should be installed on x86-64 desktop live image and thus should have a MIR filed and be in main.

so i can't run this all the way with disabling the secureboot with current xenial images. I'm happy for this to be merged once the password prompts / continue state machine logic is fixed. And then will retest again once the mokutil is promoted to main and is on the images.

review: Needs Fixing

« Back to merge proposal