Merge lp:~cyphermox/nautilus/lp625696 into lp:~ubuntu-desktop/nautilus/ubuntu

Proposed by Mathieu Trudel-Lapierre
Status: Merged
Merged at revision: 96
Proposed branch: lp:~cyphermox/nautilus/lp625696
Merge into: lp:~ubuntu-desktop/nautilus/ubuntu
Diff against target: 60 lines (+37/-0)
3 files modified
debian/changelog (+9/-0)
debian/patches/18_preedit_use_imcontext.patch (+27/-0)
debian/patches/series (+1/-0)
To merge this branch: bzr merge lp:~cyphermox/nautilus/lp625696
Reviewer Review Type Date Requested Status
Didier Roche-Tolomelli Approve
Ubuntu Desktop Pending
Review via email: mp+36301@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

That fixes the crash and I don't notice any side effects! Thanks :)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/changelog'
--- debian/changelog 2010-09-13 21:35:33 +0000
+++ debian/changelog 2010-09-22 13:59:43 +0000
@@ -1,3 +1,12 @@
1nautilus (1:2.31.92-0ubuntu2) UNRELEASED; urgency=low
2
3 * Patch typeahead search in icon/compact view to properly deal with input
4 method changes (LP: #625696)
5 - added debian/patches/18_preedit_use_imcontext.patch
6 - updated debian/patches/series
7
8 -- Mathieu Trudel-Lapierre <mathieu-tl@ubuntu.com> Wed, 22 Sep 2010 09:17:53 -0400
9
1nautilus (1:2.31.92-0ubuntu1) maverick; urgency=low10nautilus (1:2.31.92-0ubuntu1) maverick; urgency=low
211
3 * New upstream version:12 * New upstream version:
413
=== added file 'debian/patches/18_preedit_use_imcontext.patch'
--- debian/patches/18_preedit_use_imcontext.patch 1970-01-01 00:00:00 +0000
+++ debian/patches/18_preedit_use_imcontext.patch 2010-09-22 13:59:43 +0000
@@ -0,0 +1,27 @@
1From: Fumihito YOSHIDA <hito@ubuntu.com>
2Subject: Fix crash in preedit_changed handler, where nautilus crashes on
3 most IM context changes due to the missing GtkIMContext in the signal handler
4Last-Update: 2010-09-22
5
6Index: nautilus/libnautilus-private/nautilus-icon-container.c
7===================================================================
8--- nautilus.orig/libnautilus-private/nautilus-icon-container.c 2010-09-22 09:12:48.529747993 -0400
9+++ nautilus/libnautilus-private/nautilus-icon-container.c 2010-09-22 09:14:37.359747997 -0400
10@@ -4916,7 +4916,7 @@
11 * callback.
12 */
13 static void
14-nautilus_icon_container_search_preedit_changed (GtkEntry *entry,
15+nautilus_icon_container_search_preedit_changed (GtkIMContext *im_context,
16 NautilusIconContainer *container)
17 {
18 container->details->imcontext_changed = 1;
19@@ -5274,7 +5274,7 @@
20 g_signal_connect (container->details->search_entry, "activate",
21 G_CALLBACK (nautilus_icon_container_search_activate),
22 container);
23- g_signal_connect (container->details->search_entry,
24+ g_signal_connect (GTK_ENTRY (container->details->search_entry)->im_context,
25 "preedit-changed",
26 G_CALLBACK (nautilus_icon_container_search_preedit_changed),
27 container);
028
=== modified file 'debian/patches/series'
--- debian/patches/series 2010-09-13 21:35:33 +0000
+++ debian/patches/series 2010-09-22 13:59:43 +0000
@@ -5,6 +5,7 @@
512_list-view_expand.patch512_list-view_expand.patch
615_translations_list_update.patch615_translations_list_update.patch
716_desktop_menu_export.patch716_desktop_menu_export.patch
818_preedit_use_imcontext.patch
880_suppress_umount_in_ltsp.patch980_suppress_umount_in_ltsp.patch
982_gnome-app-install.patch1082_gnome-app-install.patch
1083_never_exec_nonexec_launchers.patch1183_never_exec_nonexec_launchers.patch

Subscribers

People subscribed via source and target branches

to all changes: