Code review comment for lp:~cr3/checkbox/sru

Revision history for this message
Brendan Donegan (brendan-donegan) wrote :

I was about to merge this, as I got it to work after setting the execute bit on scripts/sru_suspend, but then I noticed that in the sru_suspend script you seem to have written a test that can't fail. Is it the case that no evidence is left behind that a system failed to suspend? If so then what value is this? At the moment not having tested suspend and the suspend actually failing give equivalent results, which is just wrong.

Some chatting with cking shows that while there is not a 100% reliable method there are ways to detect that suspend/hibernate failed.

review: Needs Fixing

« Back to merge proposal