Merge lp:~cr3/checkbox/sru into lp:checkbox
Status: | Merged |
---|---|
Merged at revision: | 1148 |
Proposed branch: | lp:~cr3/checkbox/sru |
Merge into: | lp:checkbox |
Diff against target: |
267 lines (+117/-6) 15 files modified
.bzrignore (+2/-0) bin/checkbox-cli (+1/-1) bin/checkbox-gtk (+1/-1) bin/checkbox-sru (+18/-0) bin/checkbox-urwid (+1/-1) data/whitelists/sru.whitelist (+28/-0) debian/checkbox-sru.install (+2/-0) debian/checkbox-sru.links (+1/-0) debian/checkbox-sru.postinst (+7/-0) debian/control (+9/-0) debian/rules (+3/-1) examples/checkbox-sru.ini (+5/-0) jobs/sru.txt.in (+4/-0) scripts/sru_suspend (+33/-0) setup.py (+2/-2) |
To merge this branch: | bzr merge lp:~cr3/checkbox/sru |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Brendan Donegan (community) | Approve | ||
Marc Tardif (community) | Needs Resubmitting | ||
Review via email: mp+84771@code.launchpad.net |
Description of the change
This is an initial proposal for introducing SRU testing by the community. Until we clearly define how checkbox will be called, the current implementation is non-interactive and assumes being called like this:
checkbox-sru --<email address hidden>
Also note that the sru job is defined as remote because the current assumption is that there would be one script that would result in many test results. For example, the sru_suspend test results in both suspend and hibernate tests. This needs to be remote instead of local so that the test is performed during the run phase rather than the gathering phase. This might change in the future but that seems to make the most sense for now.
I have a comment about the naming. It seems like it might be wise to generalise the names of the test to describe what they do, rather than under what circumstances they're run. Also, you're clobbering my whitelist name! Thankfully it's in checkbox- certification at the moment but we did plan to move the whitelists out of checkbox- certification and into base checkbox.