Code review comment for lp:~cr3/checkbox/sru

Revision history for this message
Marc Tardif (cr3) wrote :

Thanks for the suggestion, I agree that the naming could be better. I have chosen:

  sru/suspend_success
  sru/hibernate_success

I have also taken the opportunity of improving the descriptions to be more useful. I have specifically chosen the sru/ namespace because these tests might eventually validate that you're effectively running a proposed kernel. I would like this side effect to be clearly delineated from the other tests.

As for the conflict with the checkbox-certification sru whitelist, I think it would make sense to clearly identify it as such: sru-certification.whitelist. Ideally, I would like both whitelists to eventually become one and the same, but we'll burn that bridge when we're on it...

review: Needs Resubmitting

« Back to merge proposal