Code review comment for ~cosmos-door/ubuntu/+source/byobu:fix-1845845-and-1843729

Lucas Kanashiro (lucaskanashiro) wrote :

Hi Mitsuya Shibata,

Apparently the upstream git repository is more active on Github now [1]. Maybe you should try to submit the changes you proposed here [2] there.

After taking a look at the open PR I noticed the replacement of '-e' to '--' in byobu.desktop file was already proposed here [3]. You might want to +1 that change. The only missing part is the one you proposed to fix LP: #1845845 (the FTBFS was already fixed, so no need to change debian/rules).

[1] https://github.com/dustinkirkland/byobu
[2] https://code.launchpad.net/~cosmos-door/byobu/lp1845485/+merge/373378
[3] https://github.com/dustinkirkland/byobu/pull/46

« Back to merge proposal