Ubuntu
byobu package

follow gnome-terminal libexec migration

Bug #1845845 reported by Mitsuya Shibata
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
byobu (Ubuntu)
In Progress
Medium
Unassigned

Bug Description

Debian/Ubuntu package of gnome-terminal 3.34.0 moved the server binary from /usr/lib/gnome-terminal to /usr/libexec.

byobu check /usr/lib/gnome-terminal/gnome-terminal-server in debian/postinst to decide installing which byobu.desktop or byobu.desktop.old.

current debian/postinst:
---
# Install correct .desktop file
if [ -x /usr/lib/gnome-terminal/gnome-terminal-server ]; then
        ln -sf /usr/share/$PKG/desktop/$PKG.desktop /usr/share/applications/$PKG.desktop
else
        ln -sf /usr/share/$PKG/desktop/$PKG.desktop.old /usr/share/applications/$PKG.desktop
fi
---

should be:
---
# Install correct .desktop file
if [ -x /usr/libexec/gnome-terminal-server ]; then
        ln -sf /usr/share/$PKG/desktop/$PKG.desktop /usr/share/applications/$PKG.desktop
else
        ln -sf /usr/share/$PKG/desktop/$PKG.desktop.old /usr/share/applications/$PKG.desktop
fi
---

See original description

Related branches

lp:~cosmos-door/byobu/lp1845485
Ready for review for merging into lp:byobu
Dustin Kirkland : Pending requested
Diff: 40 lines (+6/-2)
3 files modified
debian/changelog (+4/-0)
debian/postinst (+1/-1)
usr/share/byobu/desktop/byobu.desktop (+1/-1)
~cosmos-door/ubuntu/+source/byobu:fix-1845845-and-1843729
Bryce Harrington (community): Abstain
Paride Legovini: Pending requested
Andreas Hasenack: Pending requested
Diff: 81 lines (+34/-3)
5 files modified
debian/changelog (+13/-0)
debian/patches/fix-deprecated-temrinal-option.patch (+16/-0)
debian/patches/series (+1/-0)
debian/postinst (+1/-1)
debian/rules (+3/-2)
Mitsuya Shibata (cosmos-door)
description: updated
Revision history for this message
Mitsuya Shibata (cosmos-door) wrote :

Proposed merge request. could you review it?

https://code.launchpad.net/~cosmos-door/byobu/lp1845485/+merge/373378

Changed in byobu (Ubuntu):
status: New → Fix Committed
Rafael David Tinoco (rafaeldtinoco)
Changed in byobu (Ubuntu):
status: Fix Committed → In Progress
Revision history for this message
Rafael David Tinoco (rafaeldtinoco) wrote :

Mitsuya Shibata San,

I've changed flag back to In Progress. Fix Committed will be done automatically once the package lands into -proposed repository, it depends on the merge request being accepted by a reviewer and uploaded to the -proposed repo by someone with proper rights.

I see your MR solves also the issue for LP: #1843729, so I'm flagging those 2 bugs for someone to review your MR.

Thank you for your help!

Best,

Rafael

Changed in byobu (Ubuntu):
importance: Undecided → Medium
tags: added: server-next
Revision history for this message
Mitsuya Shibata (cosmos-door) wrote :

Thank you for your follow-up regarding my fault status!

Lucas Kanashiro (lucaskanashiro)
tags: removed: server-next
Revision history for this message
Athos Ribeiro (athos-ribeiro) wrote :

This is partially proposed as an upstream PR at [1]. [2] may also be relavant for anyone willing to take on this bug. Perhaps submitting the proposed patch upstream is the proper way forward here.

[1] https://github.com/dustinkirkland/byobu/pull/53
[2] https://code.launchpad.net/~cosmos-door/ubuntu/+source/byobu/+git/byobu/+merge/373861

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.