Code review comment for lp:~coreygoldberg/autopilot/fix-tests-1281733
Revision history for this message
| Thomi Richards (thomir-deactivatedaccount) wrote | # |
review:
Needs Fixing
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
1b1ed1a
(Get the code!)
A few comments:
1) you don't need to import ExpectedException any more.
2) Please rename your exception to 'InvalidArguments' - there's no need to have both ''Invalid' and 'Error' in the exception name.
3) When raising The InvalidArguments Error, just do:
raise InvalidArgument
(note the '%s' instead of '%r').
Otherwise, LGTM - make sure you run flake8 over it as well.