Merge lp:~coreygoldberg/autopilot/fix-tests-1281733 into lp:autopilot
Proposed by
Corey Goldberg
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Thomi Richards | ||||
Approved revision: | 440 | ||||
Merged at revision: | 441 | ||||
Proposed branch: | lp:~coreygoldberg/autopilot/fix-tests-1281733 | ||||
Merge into: | lp:autopilot | ||||
Diff against target: |
139 lines (+43/-16) 2 files modified
autopilot/__init__.py (+4/-0) autopilot/tests/unit/test_command_line_args.py (+39/-16) |
||||
To merge this branch: | bzr merge lp:~coreygoldberg/autopilot/fix-tests-1281733 | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
PS Jenkins bot | continuous-integration | Needs Fixing | |
Thomi Richards (community) | Approve | ||
Review via email:
|
Commit message
Fix test_command_
Description of the change
@expectedFailure decorator is breaking in python3.4,
this branch removes it's use in test_command_
all unit tests now pass in python3.4.
To post a comment you must log in.
A few comments:
1) you don't need to import ExpectedException any more.
2) Please rename your exception to 'InvalidArguments' - there's no need to have both ''Invalid' and 'Error' in the exception name.
3) When raising The InvalidArguments Error, just do:
raise InvalidArgument s("%s" % e)
(note the '%s' instead of '%r').
Otherwise, LGTM - make sure you run flake8 over it as well.