Merge lp:~corey.bryant/charms/trusty/nova-cloud-controller/proxy-none into lp:~openstack-charmers-archive/charms/trusty/nova-cloud-controller/next

Proposed by Corey Bryant
Status: Merged
Merged at revision: 169
Proposed branch: lp:~corey.bryant/charms/trusty/nova-cloud-controller/proxy-none
Merge into: lp:~openstack-charmers-archive/charms/trusty/nova-cloud-controller/next
Diff against target: 11 lines (+2/-0)
1 file modified
hooks/charmhelpers/contrib/python/packages.py (+2/-0)
To merge this branch: bzr merge lp:~corey.bryant/charms/trusty/nova-cloud-controller/proxy-none
Reviewer Review Type Date Requested Status
Liam Young (community) Approve
Review via email: mp+262895@code.launchpad.net

Description of the change

See the following charm-helpers mp for an explanation of this fix: https://code.launchpad.net/~corey.bryant/charm-helpers/proxy-none/+merge/262885

To post a comment you must log in.
Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_lint_check #5600 nova-cloud-controller-next for corey.bryant mp262895
    LINT OK: passed

Build: http://10.245.162.77:8080/job/charm_lint_check/5600/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_unit_test #5232 nova-cloud-controller-next for corey.bryant mp262895
    UNIT OK: passed

Build: http://10.245.162.77:8080/job/charm_unit_test/5232/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_amulet_test #4768 nova-cloud-controller-next for corey.bryant mp262895
    AMULET OK: passed

Build: http://10.245.162.77:8080/job/charm_amulet_test/4768/

Revision history for this message
Liam Young (gnuoy) wrote :

Approve

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'hooks/charmhelpers/contrib/python/packages.py'
--- hooks/charmhelpers/contrib/python/packages.py 2015-06-11 13:33:42 +0000
+++ hooks/charmhelpers/contrib/python/packages.py 2015-06-24 19:19:30 +0000
@@ -36,6 +36,8 @@
36def parse_options(given, available):36def parse_options(given, available):
37 """Given a set of options, check if available"""37 """Given a set of options, check if available"""
38 for key, value in sorted(given.items()):38 for key, value in sorted(given.items()):
39 if not value:
40 continue
39 if key in available:41 if key in available:
40 yield "--{0}={1}".format(key, value)42 yield "--{0}={1}".format(key, value)
4143

Subscribers

People subscribed via source and target branches