Merge lp:~corey.bryant/charm-helpers/proxy-none into lp:charm-helpers

[Corey Bryant]

pip install --proxy=None ... will fail due to: MissingSchema: Proxy URLs must have explicit schemes.

This allows pip_install(proxy=None) to be specified and --proxy won't be passed to pip_execute. Any arbitrary keyword options will be ignored if their value is null.

[Mike McCracken (mikemc)]

Should this check be for all the keys? are any of the keys expecting "--foo=None" ?

[Corey Bryant (corey.bryant)]

I think it might as well check for a blanket none on each parm. I'll update it.

[lp:~corey.bryant/charm-helpers/proxy-none]

393. By Corey Bryant on 2015-06-24

Drop any arbitrary keyword options that have null value.

[Mike McCracken (mikemc)]

LGTM

[Liam Young (gnuoy)]

Approve

review: Approve

=== modified file 'charmhelpers/contrib/python/packages.py'
--- charmhelpers/contrib/python/packages.py	2015-05-07 18:12:54 +0000
+++ charmhelpers/contrib/python/packages.py	2015-06-24 18:48:08 +0000
@@ -36,6 +36,8 @@
 def parse_options(given, available):
     """Given a set of options, check if available"""
     for key, value in sorted(given.items()):
+        if not value:
+            continue
         if key in available:
             yield "--{0}={1}".format(key, value)