Code review comment for lp:~compiz-team/compiz-core/compiz-core.fix_869316
Revision history for this message
| David Barth (dbarth) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
73416ba
(Get the code!)
A word of warning for reviews (that's you Robert ;) : please be very cautious in verifying that the change will not introduce regressions.
In particular:
- crashers due to changing conditions where a call may fail where it could not before; or a property be invalid
- behavior changes introducing regressions elsewhere
For example, I see that there are changes to if/else condition statements. Some of that can be the object of the patch. But if the condition is more restrictive or more loose on the contrary: what will happen to objects and code that were run previously if they are not processed anymore? how will objects/code behave with the new conditions, where they were never called before.