Merge lp:~compiz-team/compiz-core/compiz-core.fix_869316 into lp:compiz-core/0.9.5
Proposed by
Sam Spilsbury
Status: | Merged |
---|---|
Approved by: | David Barth |
Approved revision: | 2858 |
Merged at revision: | 2860 |
Proposed branch: | lp:~compiz-team/compiz-core/compiz-core.fix_869316 |
Merge into: | lp:compiz-core/0.9.5 |
Diff against target: |
256 lines (+103/-43) 3 files modified
src/event.cpp (+76/-6) src/stackdebugger.cpp (+5/-5) src/window.cpp (+22/-32) |
To merge this branch: | bzr merge lp:~compiz-team/compiz-core/compiz-core.fix_869316 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Robert Carr (community) | Approve | ||
Review via email: mp+78576@code.launchpad.net |
Description of the change
Fix bug 869316
To post a comment you must log in.
A word of warning for reviews (that's you Robert ;) : please be very cautious in verifying that the change will not introduce regressions.
In particular:
- crashers due to changing conditions where a call may fail where it could not before; or a property be invalid
- behavior changes introducing regressions elsewhere
For example, I see that there are changes to if/else condition statements. Some of that can be the object of the patch. But if the condition is more restrictive or more loose on the contrary: what will happen to objects and code that were run previously if they are not processed anymore? how will objects/code behave with the new conditions, where they were never called before.