Code review comment for lp:~codygarver/elementaryos/disable-idle-dim
Revision history for this message
| Sergey "Shnatsel" Davidoff (shnatsel) wrote | # |
review:
Needs Information
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
If it's about dimming the backlight, then I don't think this is a good idea. It's a good power-saving facility. Working around the Flash bug should be more targeted, e.g. make process that's spawned when Flash is started, tracks Flash usage and disables backlight when Flash is in use. Or better, start/stop hooks for Flash - wrapper script or something like that.
And Flash can be used in ads also, in which case we don't want to disable the backlight dimming... but I'm afraid this can be only fixed in Flash.
I'm personally annoyed by the fact that there are are two independent "screen-saving" facilities - one blacking it out for no real reason (gnome-screensaver) and the other properly disabling it. If it's about disabling the screensaver and not dimming the backlight, then please go ahead.