Merge lp:~codygarver/elementaryos/disable-idle-dim into lp:~elementary-os/elementaryos/default-settings-trusty
Proposed by
Cody Garver
| Status: | Merged |
|---|---|
| Approved by: | Cody Garver |
| Approved revision: | 106 |
| Merged at revision: | 106 |
| Proposed branch: | lp:~codygarver/elementaryos/disable-idle-dim |
| Merge into: | lp:~elementary-os/elementaryos/default-settings-trusty |
| Diff against target: |
13 lines (+3/-0) 1 file modified
debian/elementary-default-settings.gsettings-override (+3/-0) |
| To merge this branch: | bzr merge lp:~codygarver/elementaryos/disable-idle-dim |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Sergey "Shnatsel" Davidoff (community) | Needs Information | ||
|
Review via email:
|
|||
Commit message
Disable dimming display when idle
Description of the change
So there's this annoying bug where Flash video cannot prevent the monitor from going to sleep.
I propose we workaround this by only having 1 "display sleep" instead of 2.
As things are now, the display will dim after a few minutes idling. Then, after a few more, it fades to black and turns itself off.
I think getting rid of the initial dim will at least give us enough time for flash videos to finish and for the user to return to using the OS before the display can annoy him.
To post a comment you must log in.
Revision history for this message
| Sergey "Shnatsel" Davidoff (shnatsel) wrote | # |
review:
Needs Information
Revision history for this message
| Cody Garver (codygarver) wrote | # |
Revision history for this message
| RabbitBot (rabbitbot-a) wrote | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
If it's about dimming the backlight, then I don't think this is a good idea. It's a good power-saving facility. Working around the Flash bug should be more targeted, e.g. make process that's spawned when Flash is started, tracks Flash usage and disables backlight when Flash is in use. Or better, start/stop hooks for Flash - wrapper script or something like that.
And Flash can be used in ads also, in which case we don't want to disable the backlight dimming... but I'm afraid this can be only fixed in Flash.
I'm personally annoyed by the fact that there are are two independent "screen-saving" facilities - one blacking it out for no real reason (gnome-screensaver) and the other properly disabling it. If it's about disabling the screensaver and not dimming the backlight, then please go ahead.