Merge ~cmisare/launchpad-mojo-specs:master into launchpad-mojo-specs:master

Proposed by Colin Misare
Status: Needs review
Proposed branch: ~cmisare/launchpad-mojo-specs:master
Merge into: launchpad-mojo-specs:master
Diff against target: 20 lines (+3/-2)
1 file modified
lp/bundle.yaml (+3/-2)
Reviewer Review Type Date Requested Status
Ines Almeida Approve
Review via email: mp+455939@code.launchpad.net

Commit message

do not keep rotated haproxy logs on ppa-lb due to limited available space

To post a comment you must log in.
Revision history for this message
Ines Almeida (ines-almeida) wrote :

Thanks for proposing this. I think we will survive with less logs here

There is a comment in the lines above that needs updating. It currently says `and "rotate 52" changed to "rotate 24".` but now that is being changed to `rotate 0` here.

I can propose that in another MP if you don't want to update it in this one

review: Approve
~cmisare/launchpad-mojo-specs:master updated
b37e545... by Colin Misare

update related comment about rotate value as well

Unmerged commits

b37e545... by Colin Misare

update related comment about rotate value as well

Succeeded
[SUCCEEDED] lint:0 (build)
11 of 1 result
a119651... by Colin Misare

do not keep rotated haproxy logs on ppa-lb due to limited available space

Succeeded
[SUCCEEDED] lint:0 (build)
11 of 1 result

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
diff --git a/lp/bundle.yaml b/lp/bundle.yaml
index 740e3ff..2e23670 100644
--- a/lp/bundle.yaml
+++ b/lp/bundle.yaml
@@ -1239,12 +1239,13 @@ applications:
1239 enable_monitoring: true1239 enable_monitoring: true
1240 # ppa-lb's logs mostly duplicate those of ppa-apache2, and are very1240 # ppa-lb's logs mostly duplicate those of ppa-apache2, and are very
1241 # large. This is the default with "daily" changed to "hourly", the1241 # large. This is the default with "daily" changed to "hourly", the
1242 # addition of "dateext", and "rotate 52" changed to "rotate 24".1242 # addition of "dateext", and "rotate 52" changed to "rotate 0".
1243 logrotate_config: |1243 logrotate_config: |
1244 /var/log/haproxy.log {1244 /var/log/haproxy.log {
1245 hourly1245 hourly
1246 dateext1246 dateext
1247 rotate 241247 # save no rotated files due to limited available space
1248 rotate 0
1248 missingok1249 missingok
1249 notifempty1250 notifempty
1250 compress1251 compress

Subscribers

People subscribed via source and target branches