Code review comment for lp:~clint-fewbar/pyjuju/fix-tests-without-aws-access-key-id

Revision history for this message
Gustavo Niemeyer (niemeyer) wrote :

Actually, that doesn't look entirely ok. One issue we have to solve before merging this:

[1]

Which tests are failing, and why?

Changing EnvironmentsConfigTestBase to set the AWS variables at _all_ times is creating
an unrealistic environment for the tests to run under. The environment itself should
generally work without these variables being set.

I'm happy to set the variables in specific tests where it's clear that mocking the
values is desired, but otherwise if the code is requiring the AWS varaibles to be set
in situations it shouldn't, it is the code that should be fixed.

review: Needs Fixing

« Back to merge proposal