Merge lp:~clint-fewbar/pyjuju/fix-tests-without-aws-access-key-id into lp:pyjuju

[Clint Byrum]

Trivial change to make sure tests do not fail because of missing AWS_* variables.

[Gustavo Niemeyer (niemeyer)]

Looks good, thanks Clint.

review: Approve

[Gustavo Niemeyer (niemeyer)]

Actually, that doesn't look entirely ok. One issue we have to solve before merging this:

[1]

Which tests are failing, and why?

Changing EnvironmentsConfigTestBase to set the AWS variables at _all_ times is creating
an unrealistic environment for the tests to run under. The environment itself should
generally work without these variables being set.

I'm happy to set the variables in specific tests where it's clear that mocking the
values is desired, but otherwise if the code is requiring the AWS varaibles to be set
in situations it shouldn't, it is the code that should be fixed.

review: Needs Fixing

[Clint Byrum (clint-fewbar)]

I think I see the problem a little clearer now, and the real issue is that there are actually bugs in some assumptions made in the EC2 provider about how txaws works.. so this will need more thought. For now I'll keep this patch in the package build steps so we can run all the other tests, but the bug itself is perhaps a symptom of something much deeper.

[Kapil Thangavelu (hazmat)]

marking this merge as abandonded, there are about 3 config tests that fail without this env var set, we should go ahead and set them in the relevant tests, clearing out of the lp review queue.

Unmerged revisions

337. By Clint Byrum on 2011-09-01

override AWS_ACCESS_KEY_ID and AWS_SECRET_ACCESS_KEY to prevent txaws from raising errors

=== modified file 'ensemble/environment/tests/test_config.py'
--- ensemble/environment/tests/test_config.py	2011-08-09 19:25:58 +0000
+++ ensemble/environment/tests/test_config.py	2011-09-01 00:19:16 +0000
@@ -47,7 +47,7 @@
         yield super(EnvironmentsConfigTestBase, self).setUp()
         self.old_home = os.environ.get("HOME")
         self.tmp_home = self.makeDir()
-        self.change_environment(HOME=self.tmp_home)
+        self.change_environment(HOME=self.tmp_home, AWS_ACCESS_KEY_ID="foo", AWS_SECRET_ACCESS_KEY="bar")
         self.default_path = os.path.join(self.tmp_home,
                                          ".ensemble/environments.yaml")
         self.other_path = os.path.join(self.tmp_home,