Code review comment for lp:~clint-fewbar/charm-tools/charm-tests-spec
Revision history for this message
| Jelmer Vernooij (jelmer) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
73416ba
(Get the code!)
This seems very reasonable. Some nitpicky comments:
It seems that a non-zero exit code indicates a failure, and a zero exit code indicates success? I guess this is fairly standard, but it would be nice to have it documented explicitly. Is it necessary to use 1 for failure (and perhaps anything else for errors), or is any non-zero exit code sufficient?
Based on the example, it also seems like results can be reported to stdout. Is the "ERROR: " prefix necessary for problems, and how many ERROR: lines can there be? What happens to output that doesn't start with ERROR: or INFO: ? What happens with stderr?
Do packages listed in requirements.yaml have to be in main, or can they be in universe/multiverse too?