Merge lp:~clint-fewbar/charm-tools/charm-tests-spec into lp:~charmers/charm-tools/trunk
Proposed by
Clint Byrum
Status: | Merged |
---|---|
Merged at revision: | 122 |
Proposed branch: | lp:~clint-fewbar/charm-tools/charm-tests-spec |
Merge into: | lp:~charmers/charm-tools/trunk |
Diff against target: |
188 lines (+182/-0) 1 file modified
doc/source/charm-tests.rst (+182/-0) |
To merge this branch: | bzr merge lp:~clint-fewbar/charm-tools/charm-tests-spec |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
charmers | Pending | ||
Review via email: mp+90232@code.launchpad.net |
Description of the change
This is a specification for implementing automated tests for the approved juju charms. It is being generated from this branch into an HTML file every 15 minutes here:
To post a comment you must log in.
This seems very reasonable. Some nitpicky comments:
It seems that a non-zero exit code indicates a failure, and a zero exit code indicates success? I guess this is fairly standard, but it would be nice to have it documented explicitly. Is it necessary to use 1 for failure (and perhaps anything else for errors), or is any non-zero exit code sufficient?
Based on the example, it also seems like results can be reported to stdout. Is the "ERROR: " prefix necessary for problems, and how many ERROR: lines can there be? What happens to output that doesn't start with ERROR: or INFO: ? What happens with stderr?
Do packages listed in requirements.yaml have to be in main, or can they be in universe/multiverse too?