Code review comment for lp:~cjwatson/vmbuilder/chroot-grub

Revision history for this message
Soren Hansen (soren) wrote :

On Thu, Oct 08, 2009 at 10:54:11AM -0000, Colin Watson wrote:
>On Thu, Oct 08, 2009 at 10:48:12AM -0000, Soren Hansen wrote:
>> On Mon, Oct 05, 2009 at 11:10:25AM -0000, Colin Watson wrote:
>>> + def install_bootloader_cleanup(self):
>>> + self.vm.cancel_cleanup(self.install_bootloader_cleanup)
>>
>> Clever! I can think of a bunch of places this would be useful.
> Not my idea, actually; I borrowed it from
> VMBuilder.disk.Filesystem.umount. :-)

Wow, and "bzr blame" says I wrote that bit. Talk about a brief moment of
clarity :)

--
Soren Hansen |
Lead virtualisation engineer | Ubuntu Server Team
Canonical Ltd. | http://www.ubuntu.com/

« Back to merge proposal