Merge ~cjwatson/lazr.delegates:rhinectomy into lazr.delegates:main
Status: | Merged |
---|---|
Approved by: | Colin Watson |
Approved revision: | 5e48801f78161f22fa360ec9ad46e2dd3b2f710a |
Merged at revision: | 5e48801f78161f22fa360ec9ad46e2dd3b2f710a |
Proposed branch: | ~cjwatson/lazr.delegates:rhinectomy |
Merge into: | lazr.delegates:main |
Diff against target: |
291 lines (+102/-26) 7 files modified
.gitignore (+1/-0) NEWS.rst (+1/-0) dev/null (+0/-9) lazr/delegates/tests/test_docs.py (+67/-0) lazr/delegates/tests/test_python2.py (+2/-9) setup.py (+0/-6) tox.ini (+31/-2) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Jürgen Gmach | Approve | ||
Review via email: mp+412127@code.launchpad.net |
Commit message
Test using zope.testrunner rather than nose
Description of the change
`nose` is unmaintained and doesn't work with Python 3.10. There's `nose2`, but using `zope.testrunner` brings this more into line with other lazr.* projects.
Coverage currently appears fairly terrible, but will improve dramatically once we drop Python 2 support. I could have done Python 2 and 3 runs and combined the coverage output, but it didn't seem worth the complexity when we're likely to be dropping Python 2 support from here soon anyway.
Pre-empting an obvious question: I don't necessarily object to using the `pytest` runner instead, but I thought it better to start by using the same thing as most other lazr.* projects, and we can consider switching them all over in one go later.
Python 2.6 support was already dropped in 2015, but apparently accidentally not removed from `setup.py`, and since I needed to adjust how tests are skipped as part of this work in a way that definitely wouldn't work with Python 2.6 I took the opportunity to update that.
LGTM
We can drop the very old Python 3 version in another MP.
I have created a MP based on yours with combined coverage - I never did that before, but I thought it would be fun to try out.
I will propose it once your's have landed.