Code review comment for ~cjwatson/lazr.delegates:rhinectomy

Revision history for this message
Colin Watson (cjwatson) wrote :

Some of these are "else fail" kind of constructs, where I think "# pragma: no cover" would be suitable. But yes, let's check after dropping Python 2.

FYI you can propose MPs based on unlanded ones without having to wait for them to land, by using the "prerequisite branch" facility (this doesn't exist on GitHub so you may not be familiar with it). Though as I mentioned I wonder whether combined coverage is worth the complexity when we'll be dropping Python 2 support anyway?

« Back to merge proposal