Code review comment for ~cjwatson/launchpadlib:pyupgrade

Revision history for this message
Jürgen Gmach (jugmac00) wrote :

Personally I like the % and f-string formatting and the format thing not so much.

I would have ran pyupgrade with `--keep-percent-format` until we are on Python 3.6 and use f-strings, but as I said this is a very personal thing, and certainly no blocker :-)

LGTM!

review: Approve

« Back to merge proposal