Merge ~cjwatson/launchpadlib:pyupgrade into launchpadlib:main

[Colin Watson]

Apply pyupgrade

[Jürgen Gmach (jugmac00)]

Personally I like the % and f-string formatting and the format thing not so much.

I would have ran pyupgrade with `--keep-percent-format` until we are on Python 3.6 and use f-strings, but as I said this is a very personal thing, and certainly no blocker :-)

LGTM!

review: Approve

[Colin Watson (cjwatson)]

Fine by me. I've added `--keep-percent-format` - how's this?

[Jürgen Gmach (jugmac00)]

Excellent :-)

diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
index fe333f3..7304ab5 100644
--- a/.pre-commit-config.yaml
+++ b/.pre-commit-config.yaml
@@ -15,6 +15,11 @@ repos:
     rev: 3.9.2
     hooks:
     -   id: flake8
+-   repo: https://github.com/asottile/pyupgrade
+    rev: v2.29.0
+    hooks:
+    -   id: pyupgrade
+        args: [--keep-percent-format]
 -   repo: https://github.com/psf/black
     rev: 21.9b0
     hooks:
diff --git a/src/launchpadlib/launchpad.py b/src/launchpadlib/launchpad.py
index cbe5cbd..9363d9b 100644
--- a/src/launchpadlib/launchpad.py
+++ b/src/launchpadlib/launchpad.py
@@ -243,9 +243,7 @@ class Launchpad(ServiceRoot):
 
     @classmethod
     def _is_sudo(cls):
-        return set(["SUDO_USER", "SUDO_UID", "SUDO_GID"]) & set(
-            os.environ.keys()
-        )
+        return {"SUDO_USER", "SUDO_UID", "SUDO_GID"} & set(os.environ.keys())
 
     @classmethod
     def authorization_engine_factory(cls, *args):
diff --git a/src/launchpadlib/testing/launchpad.py b/src/launchpadlib/testing/launchpad.py
index c3d65bc..a97b995 100644
--- a/src/launchpadlib/testing/launchpad.py
+++ b/src/launchpadlib/testing/launchpad.py
@@ -411,9 +411,7 @@ class FakeResource(object):
             name or if C{value}'s type is not valid for the attribute.
         """
         representation = self._application.representation_definitions[xml_id]
-        parameters = dict(
-            (child.get("name"), child) for child in representation.tag
-        )
+        parameters = {child.get("name"): child for child in representation.tag}
         if name not in parameters:
             raise IntegrityError("%s not found" % name)
         parameter = parameters[name]