Merge lp:~cjwatson/launchpad/publish-proposed into lp:launchpad
Status: | Merged |
---|---|
Approved by: | Richard Harding |
Approved revision: | no longer in the source branch. |
Merged at revision: | 15068 |
Proposed branch: | lp:~cjwatson/launchpad/publish-proposed |
Merge into: | lp:launchpad |
Diff against target: |
86 lines (+45/-3) 2 files modified
lib/lp/registry/model/distroseries.py (+5/-2) lib/lp/registry/tests/test_distroseries.py (+40/-1) |
To merge this branch: | bzr merge lp:~cjwatson/launchpad/publish-proposed |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
j.c.sackett (community) | Approve | ||
Richard Harding (community) | code* | Approve | |
Review via email: mp+100985@code.launchpad.net |
Commit message
Fix publishing of pre-release uploads to the PROPOSED pocket.
Description of the change
== Summary ==
As reported in bug 974328, pre-release uploads to Ubuntu precise-proposed are accepted and built but cannot be published.
== Proposed fix ==
I basically just missed a case in my previous fix to allow using -proposed as a staging pocket, and need to permit it in checkLegalPocket as well for publishing.
== Implementation details ==
I'm +37 on LoC for this branch. I need to get this fixed fairly promptly if possible, so perhaps I could use some of the -531 credit from r15032 against this?
== Tests ==
bin/test -vvct checkLegalPocket
(I didn't see any more sensible place to test this, so it seemed best to just add unit tests at the finest possible granularity.)
== Demo and Q/A ==
I think we need an end-to-end test now to make sure there's nothing else, so:
* Upload a test package (say, hello) to oneiric-proposed on dogfood. (oneiric is DEVELOPMENT there.)
* Process the upload and wait for it to build everywhere.
* Do a full publisher run. Ensure that it is actually published.
* Copy the package to oneiric.
* Do another full publisher run. Ensure that the copy is actually published.
(Unfortunately this will take a while, dogfood being what it is.)
== lint ==
None.
Thanks for the update. Per the test style guide, please add docstrings to the tests. /dev.launchpad. net/TestsStyleG uide#line- 416
https:/
I'm also tempted to ask that the test conditions match the name. It seems backwards that the test "forbids" and yet the assertion is assertTrue as in the tests that "allows".
The change itself looks fine though. Approving the MP with these suggestions.