Code review comment for lp:~cjwatson/launchpad/publish-proposed

Revision history for this message
Richard Harding (rharding) wrote :

Thanks for the update. Per the test style guide, please add docstrings to the tests.
https://dev.launchpad.net/TestsStyleGuide#line-416

I'm also tempted to ask that the test conditions match the name. It seems backwards that the test "forbids" and yet the assertion is assertTrue as in the tests that "allows".

The change itself looks fine though. Approving the MP with these suggestions.

review: Approve (code*)

« Back to merge proposal