Code review comment for lp:~cjwatson/launchpad/failure-count-reset

Revision history for this message
William Grant (wgrant) wrote :

The resume won't actually occur, because you don't pass back the Deferred returned by resetOrFail. Otherwise this looks fine, as long as the failnotes still have reasonable content.

review: Needs Fixing (code)

« Back to merge proposal