Merge lp:~cjwatson/launchpad/failure-count-reset into lp:launchpad
Proposed by
Colin Watson
Status: | Merged |
---|---|
Approved by: | Colin Watson |
Approved revision: | no longer in the source branch. |
Merged at revision: | 16752 |
Proposed branch: | lp:~cjwatson/launchpad/failure-count-reset |
Merge into: | lp:launchpad |
Diff against target: |
319 lines (+114/-60) 3 files modified
lib/lp/buildmaster/manager.py (+24/-7) lib/lp/buildmaster/model/builder.py (+8/-3) lib/lp/buildmaster/tests/test_manager.py (+82/-50) |
To merge this branch: | bzr merge lp:~cjwatson/launchpad/failure-count-reset |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
William Grant | code | Approve | |
Review via email: mp+183320@code.launchpad.net |
Commit message
Try to reset virtual builders a couple of times before giving up and failing them.
Description of the change
buildd-manager often determines that a virtual builder has failed without trying to reset it first. As discussed with William, this branch arranges to try to ppa-reset it twice before giving up, going through the usual failure counting in between resets. It will take three times as long to fail a builder completely if it's really unrecoverable, but hopefully many of them can be brought back by way of these automatic ppa-resets.
To post a comment you must log in.
The resume won't actually occur, because you don't pass back the Deferred returned by resetOrFail. Otherwise this looks fine, as long as the failnotes still have reasonable content.