Merge lp:~cjwatson/launchpad-buildd/livefs-remove-suite-compat into lp:launchpad-buildd

Proposed by Colin Watson
Status: Merged
Approved by: William Grant
Approved revision: 122
Merged at revision: 122
Proposed branch: lp:~cjwatson/launchpad-buildd/livefs-remove-suite-compat
Merge into: lp:launchpad-buildd
Diff against target: 38 lines (+4/-13)
2 files modified
debian/changelog (+2/-0)
lpbuildd/livefs.py (+2/-13)
To merge this branch: bzr merge lp:~cjwatson/launchpad-buildd/livefs-remove-suite-compat
Reviewer Review Type Date Requested Status
William Grant code Approve
Review via email: mp+224802@code.launchpad.net

Commit message

Stop accepting the "suite" argument to livefs builds, now that Launchpad has been updated to use the newer series/pocket protocol.

Description of the change

Now that launchpad-buildd 123 has been deployed everywhere (including staging), and Launchpad has been updated to use the new series/pocket protocol for livefs builds, we can drop the old suite protocol.

To post a comment you must log in.
Revision history for this message
William Grant (wgrant) :
review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/changelog'
--- debian/changelog 2014-06-25 01:55:57 +0000
+++ debian/changelog 2014-06-27 12:21:54 +0000
@@ -14,6 +14,8 @@
14 [ Colin Watson ]14 [ Colin Watson ]
15 * Install ltsp-server (but not its Recommends) for i386 livefs builds, as15 * Install ltsp-server (but not its Recommends) for i386 livefs builds, as
16 Edubuntu needs it.16 Edubuntu needs it.
17 * Stop accepting the "suite" argument to livefs builds, now that Launchpad
18 has been updated to use the newer series/pocket protocol.
1719
18 -- Colin Watson <cjwatson@ubuntu.com> Tue, 24 Jun 2014 14:58:16 +010020 -- Colin Watson <cjwatson@ubuntu.com> Tue, 24 Jun 2014 14:58:16 +0100
1921
2022
=== modified file 'lpbuildd/livefs.py'
--- lpbuildd/livefs.py 2014-06-15 23:40:27 +0000
+++ lpbuildd/livefs.py 2014-06-27 12:21:54 +0000
@@ -42,19 +42,8 @@
42 self.subarch = extra_args.get("subarch")42 self.subarch = extra_args.get("subarch")
43 self.project = extra_args["project"]43 self.project = extra_args["project"]
44 self.subproject = extra_args.get("subproject")44 self.subproject = extra_args.get("subproject")
45 if "series" in extra_args:45 self.series = extra_args["series"]
46 self.series = extra_args["series"]46 self.pocket = extra_args["pocket"]
47 self.pocket = extra_args["pocket"]
48 else:
49 # For compatibility; remove once launchpad-buildd 123 is
50 # deployed in production and the Launchpad master has been
51 # adjusted to pass series and pocket rather than suite.
52 suite = extra_args["suite"]
53 if "-" in suite:
54 self.series, self.pocket = suite.rsplit("-", 1)
55 else:
56 self.series = suite
57 self.pocket = "release"
58 self.datestamp = extra_args.get("datestamp")47 self.datestamp = extra_args.get("datestamp")
59 self.image_format = extra_args.get("image_format")48 self.image_format = extra_args.get("image_format")
60 self.locale = extra_args.get("locale")49 self.locale = extra_args.get("locale")

Subscribers

People subscribed via source and target branches

to all changes: